john-bodley edited a comment on pull request #12903: URL: https://github.com/apache/superset/pull/12903#issuecomment-773015742
I still don’t really see much value in showing UI elements (even if they’re disable) which take up pristine real estate if the datasource does not support temporal functionality. My arm could be twisted in terms of an indication to the user (via a link in a condensed form the the component) as to how one could declare a column as being temporal. Chart controls are already vary by visualization type including time, i.e., only a subset support time buckets. Furthermore we should likely extend this logic to filterable/groupable columns. If these don’t exist for the datasource there is limited value in showing the associated controls if they’re unusable. The one caveat (covering my arse) is I’m uncertain what the end state is for the explorer redesign with the left-hand-panel and proposed drag-and-drop functionality, but I speculate the above logic will still hold, i.e., why show a component where the drop target will never be eligible. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
