robdiciuccio commented on pull request #12903: URL: https://github.com/apache/superset/pull/12903#issuecomment-772953339
> Currently users have to select "Is temporal" for a column to appear in the Time Column select. So this inference is at least guaranteed to be consistent with the Time column choices. The "is temporal" option is automatically checked for certain column types when creating a dataset, so many users are likely unaware of these column settings. My main point was, if this column type auto-detection fails for whatever reason, the time filter options will be fully hidden from the user, even though there may be a viable temporal column that just needs to be manually configured. > If the Time column choice is empty, then filtering by time range is indeed impossible for the specific chart, right? Yes, we display a "No options" message in the filter column selector. Perhaps the existing time filter UI could be replaced in this case with a message (only visible upon toggling the filter open) saying "there are no temporal columns configured for this dataset, click here to add one." ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
