rusackas commented on a change in pull request #12920:
URL: https://github.com/apache/superset/pull/12920#discussion_r578215492
##########
File path: superset-frontend/src/common/components/Collapse/index.tsx
##########
@@ -18,11 +18,10 @@
*/
import React from 'react';
import { styled } from '@superset-ui/core';
-// eslint-disable-next-line no-restricted-imports
-import { Collapse as AntdCollapse } from 'antd';
+import { Collapse as AntdCollapse } from 'src/common/components';
Review comment:
I feel like our patterns have become a bit scattered, but if we want to
encourage the use of THIS `Collapse` component, then we should probably import
the AntD one directly from `antd` here, and NOT export the AntD `Collapse`
component in `common/components/index.tsx`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
