etr2460 commented on a change in pull request #13606:
URL: https://github.com/apache/superset/pull/13606#discussion_r594467719
##########
File path: superset-frontend/src/datasource/DatasourceEditor.jsx
##########
@@ -918,6 +919,30 @@ class DatasourceEditor extends React.PureComponent {
/>
}
/>
+ <Field
+ label={t('Deprecated at')}
+ fieldKey="deprecated_at"
+ description={t('The date this metric is or will be
deprecated')}
+ control={
+ <TextControl
+ controlId="deprecated_at"
+ placeholder="YYYY-MM-DD"
+ />
+ }
+ />
+ <Field
+ label={t('Deprecation link')}
+ fieldKey="deprecation_link"
+ description={t(
+ 'A link with more details regarding the deprecation of this
metric',
+ )}
+ control={
+ <TextControl
+ controlId="deprecation_link"
+ placeholder="https://www.example.com";
+ />
+ }
+ />
Review comment:
I don't think forcing a new tab in markdown is possible unless you use
html `a` tags. i can play around a bit with supporting markdown descriptions.
it's a bit less structured (which i'm not sure if that's good or bad).
For context, in internal use, the learn more link typically goes to a google
doc or something else with lots of detailed, freeform content. So we made the
choice in other products to just link out to there instead of making people
write more context/details in product
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
