bkyryliuk commented on a change in pull request #13606:
URL: https://github.com/apache/superset/pull/13606#discussion_r594497269
##########
File path: superset/connectors/sqla/models.py
##########
@@ -412,9 +412,23 @@ def certified_by(self) -> Optional[str]:
def certification_details(self) -> Optional[str]:
return self.get_extra_dict().get("certification", {}).get("details")
+ @property
+ def deprecated_at(self) -> Optional[str]:
+ return self.get_extra_dict().get("deprecated_at")
+
+ @property
+ def deprecation_link(self) -> Optional[str]:
+ return self.get_extra_dict().get("deprecation_link")
+
@property
def data(self) -> Dict[str, Any]:
- attrs = ("is_certified", "certified_by", "certification_details")
+ attrs = (
+ "is_certified",
+ "certified_by",
+ "certification_details",
+ "deprecated_at",
Review comment:
it may be nice to have deprecated_by field as well to have point of
contact
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
