villebro commented on a change in pull request #13606:
URL: https://github.com/apache/superset/pull/13606#discussion_r594562659
##########
File path: superset-frontend/src/datasource/DatasourceEditor.jsx
##########
@@ -918,6 +919,30 @@ class DatasourceEditor extends React.PureComponent {
/>
}
/>
+ <Field
+ label={t('Deprecated at')}
+ fieldKey="deprecated_at"
+ description={t('The date this metric is or will be
deprecated')}
+ control={
+ <TextControl
+ controlId="deprecated_at"
+ placeholder="YYYY-MM-DD"
+ />
+ }
+ />
+ <Field
+ label={t('Deprecation link')}
+ fieldKey="deprecation_link"
+ description={t(
+ 'A link with more details regarding the deprecation of this
metric',
+ )}
+ control={
+ <TextControl
+ controlId="deprecation_link"
+ placeholder="https://www.example.com";
+ />
+ }
+ />
Review comment:
I found this, and making the following change seems to send the links to
`_blank`:
```patch
diff --git
a/superset-frontend/src/dashboard/components/gridComponents/Markdown.jsx
b/superset-frontend/src/dashboard/components/gridComponents/Markdown.jsx
index b071a9982..5b30cd400 100644
--- a/superset-frontend/src/dashboard/components/gridComponents/Markdown.jsx
+++ b/superset-frontend/src/dashboard/components/gridComponents/Markdown.jsx
@@ -286,6 +286,7 @@ class Markdown extends React.PureComponent {
isValidNode: node => node.type !== 'script',
}),
]}
+ linkTarget="_blank"
/>
);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
