etr2460 commented on pull request #13606: URL: https://github.com/apache/superset/pull/13606#issuecomment-799866246
A bunch of good suggestions here, thanks for the comments! I think if we're going to provide the flexibility of free text, then we should let the user add whatever content they want there (links, POCs, descriptions, replacements, etc.) and not worry about structuring it more. However, making this a generic warning might be even better. If we want to take the flexible route, then we could get rid of the deprecated_at field too and just rely on everything to be provided in markdown. Then it's just one simple field that anyone could use for whatever purpose. Super extensible for other users, and would serve the deprecation use case. I'm going to simplify and move forward with a generic `warning_markdown` field that can be added to a metric or dataset. Will tag y'all when that's ready ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
