a-cid commented on a change in pull request #13556:
URL: https://github.com/apache/superset/pull/13556#discussion_r599956050
##########
File path: superset/db_engine_specs/athena.py
##########
@@ -64,3 +73,37 @@ def _mutate_label(label: str) -> str:
:return: Conditionally mutated label
"""
return label.lower()
+
+ @classmethod
+ def create_table_from_csv( # pylint: disable=too-many-arguments
Review comment:
After having the time to further test the feature I can see this fix
clearly needs additional work. Append and Replace are not supported and can
corrupt/duplicate your data if used. Will try to do a more proper
implementation following @bkyryliuk's advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
