a-cid commented on a change in pull request #13556:
URL: https://github.com/apache/superset/pull/13556#discussion_r591873384
##########
File path: superset/db_engine_specs/athena.py
##########
@@ -64,3 +73,37 @@ def _mutate_label(label: str) -> str:
:return: Conditionally mutated label
"""
return label.lower()
+
+ @classmethod
+ def create_table_from_csv( # pylint: disable=too-many-arguments
Review comment:
Sorry, I'm confused. Aren't these csv controls already handled by
`csv_to_df`?
Are you suggesting to move the csv controls to the create table definition
and upload the file as it is, like in the example you linked?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
