a-cid commented on a change in pull request #13556:
URL: https://github.com/apache/superset/pull/13556#discussion_r591805276
##########
File path: superset/db_engine_specs/athena.py
##########
@@ -64,3 +73,37 @@ def _mutate_label(label: str) -> str:
:return: Conditionally mutated label
"""
return label.lower()
+
+ @classmethod
+ def create_table_from_csv( # pylint: disable=too-many-arguments
Review comment:
Agreed it does seem cleaner and it was my first idea for solving this,
but I fear even with a lower chunk size we may still run into problems when
trying to upload certain datasets (e.g. CSVs containing long text columns)
pyathena's to_csv converts the dataframe to parquet and uploads it to S3,
bypassing this limitation completely
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
