bkyryliuk commented on a change in pull request #13556:
URL: https://github.com/apache/superset/pull/13556#discussion_r591826197
##########
File path: superset/db_engine_specs/athena.py
##########
@@ -64,3 +73,37 @@ def _mutate_label(label: str) -> str:
:return: Conditionally mutated label
"""
return label.lower()
+
+ @classmethod
+ def create_table_from_csv( # pylint: disable=too-many-arguments
Review comment:
I see, in that case I would suggest to follow:
https://github.com/apache/superset/blob/efeb5a93e62440ddf16f16aa0bd8aeac52eac4d5/superset/db_engine_specs/hive.py#L191
and implement support for various csv controls like null values, custom
separator etc
looks like not all of those supported here:
https://github.com/laughingman7743/PyAthena/blob/5942373e31668367ddd2fb9fdd3b9c496d388ec7/pyathena/pandas/util.py#L134
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
