etr2460 commented on pull request #13802: URL: https://github.com/apache/superset/pull/13802#issuecomment-808305953
>Do you think it would be ok to change this so that this logic only applies to the bar chart? @villebro Yeah, I could certainly make that change. Wasn't sure if this change was desirable for other time series visualizations though. I don't know if a line chart with a series of all 0s even renders in the nvd3 chart, i'll verify @michael-s-molina I 100% agree with all of your points, 0 and null can have very different meanings. This edge case is a bit different though. I'm only removing time series that are completely composed of 0s or nulls (modifying from the previous behavior of only removing time series that are completely composed of nulls). If a time series has a positive or negative value anywhere in the series, it won't be affected by this change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
