[GitHub] [superset] etr2460 commented on pull request #13802: feat: don't return empty time-series

[GitBox]

etr2460 commented on pull request #13802:
URL: https://github.com/apache/superset/pull/13802#issuecomment-808369067


   >Thinking here, what if we have a line chart where each line represents the 
number of daily deaths by Covid for a specific US state? We could have states 
with zero deaths throughout the days or a state that is failing to report cases.
   
   Yup, I agree. That's the granularity this change loses. What's interesting 
is that while in the line and area chart the tooltip shows an `all 0s` and a 
`mixed 0 and null` series:
   <img width="1279" alt="Screen Shot 2021-03-26 at 9 46 27 AM" 
src="https://user-images.githubusercontent.com/7409244/112665776-a5fb4800-8e18-11eb-9833-1a98d95c083f.png";>
   
   The tooltip on the time series bar chart doesn't:
   <img width="1290" alt="Screen Shot 2021-03-26 at 9 48 52 AM" 
src="https://user-images.githubusercontent.com/7409244/112665879-c0cdbc80-8e18-11eb-9193-f574583daa11.png";>
   
   One nuance I was missing in my test case was that these charts had the 
legends disabled too, which made the time series bar chart especially hard to 
tell what was going on.
   
   After all this investigation, would adding a new chart config to exclude 0 
and null series from the chart be a reasonable approach?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org