rusackas commented on a change in pull request #13306:
URL: https://github.com/apache/superset/pull/13306#discussion_r605909867
##########
File path:
superset-frontend/cypress-base/cypress/integration/dashboard/load.test.ts
##########
@@ -23,12 +23,18 @@ import {
} from './dashboard.helper';
describe('Dashboard load', () => {
- before(() => {
+ beforeEach(() => {
cy.login();
- cy.visit(WORLD_HEALTH_DASHBOARD);
});
it('should load dashboard', () => {
+ cy.visit(WORLD_HEALTH_DASHBOARD);
WORLD_HEALTH_CHARTS.forEach(waitForChartLoad);
});
+
+ it('should load in edit/standalone mode', () => {
+ cy.visit(`${WORLD_HEALTH_DASHBOARD}?edit=true&standalone=true`);
Review comment:
Would there be any value in testing the other permutations of these
params, and making sure the view is in the expected state/configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
