rusackas commented on a change in pull request #13306:
URL: https://github.com/apache/superset/pull/13306#discussion_r605916461
##########
File path: superset-frontend/src/dashboard/App.jsx
##########
@@ -25,22 +25,28 @@ import { HTML5Backend } from 'react-dnd-html5-backend';
import { DynamicPluginProvider } from 'src/components/DynamicPlugins';
import setupApp from '../setup/setupApp';
import setupPlugins from '../setup/setupPlugins';
-import DashboardContainer from './containers/Dashboard';
+import DashboardRoute from './components/DashboardPage';
import { theme } from '../preamble';
setupApp();
setupPlugins();
-const App = ({ store }) => (
- <Provider store={store}>
- <DndProvider backend={HTML5Backend}>
- <ThemeProvider theme={theme}>
- <DynamicPluginProvider>
- <DashboardContainer />
- </DynamicPluginProvider>
- </ThemeProvider>
- </DndProvider>
- </Provider>
-);
+const App = ({ store }) => {
+ const dashboardIdOrSlug = window.location.pathname.split('/')[3];
+ return (
+ <Provider store={store}>
+ <DndProvider backend={HTML5Backend}>
+ <ThemeProvider theme={theme}>
+ <DynamicPluginProvider>
Review comment:
Maybe we need a `ProviderProvider` ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
