rusackas commented on a change in pull request #13306:
URL: https://github.com/apache/superset/pull/13306#discussion_r605910851
##########
File path:
superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts
##########
@@ -61,9 +61,12 @@ describe('Nativefilters', () => {
.click()
.type('Country name');
- cy.get('.ant-modal').find('[data-test="datasource-input"]').click();
+ cy.get('.ant-modal')
+ .find('[data-test="datasource-input"]')
+ .click()
+ .type('wb_health_population');
- cy.get('[data-test="datasource-input"]')
+ cy.get('.ant-modal [data-test="datasource-input"] .Select__menu')
Review comment:
Not a problem, but I'm curious why we need the `.ant-modal` selector
here. Mainly wondering if our data-test attribute is too general and should
just be made more specific.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
