rusackas commented on a change in pull request #13306:
URL: https://github.com/apache/superset/pull/13306#discussion_r605966640



##########
File path: superset-frontend/src/dashboard/actions/hydrate.js
##########
@@ -79,7 +113,7 @@ export default function getInitialState(bootstrapData) {
   }
 
   // dashboard layout
-  const { position_json: positionJson } = dashboard;
+  const positionJson = JSON.parse(dashboardData.position_json);

Review comment:
       var name nit: once parsed, it's just the positionObj or positionValue or 
something, right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to