Copilot commented on code in PR #6797:
URL: https://github.com/apache/texera/pull/6797#discussion_r3634718369
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/common/PekkoActorRefMappingService.scala:
##########
@@ -76,13 +76,13 @@ class PekkoActorRefMappingService(actorService:
PekkoActorService) extends Amber
def removeActorRef(id: ActorVirtualIdentity): Unit = {
if (actorRefMapping.contains(id)) {
val ref = actorRefMapping.remove(id).get
- logger.warn(s"actor $id is not reachable anymore, it might have crashed.
old ref = $ref")
+ logger.debug(s"actor $id is not reachable anymore, it might have
crashed. old ref = $ref")
}
Review Comment:
This log message is now DEBUG (good for noise), but the wording still
implies a crash ("not reachable... might have crashed") even though
`removeActorRef` is also called during normal graceful termination (e.g.,
RegionExecutionManager removes refs before `gracefulStop`). Consider making the
message neutral so DEBUG logs aren’t misleading when enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
