aglinxinyuan commented on code in PR #6797:
URL: https://github.com/apache/texera/pull/6797#discussion_r3648726682
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/common/PekkoActorRefMappingService.scala:
##########
@@ -76,13 +76,13 @@ class PekkoActorRefMappingService(actorService:
PekkoActorService) extends Amber
def removeActorRef(id: ActorVirtualIdentity): Unit = {
if (actorRefMapping.contains(id)) {
val ref = actorRefMapping.remove(id).get
- logger.warn(s"actor $id is not reachable anymore, it might have crashed.
old ref = $ref")
+ logger.debug(s"removed actor ref for $id. old ref = $ref")
Review Comment:
I actually spent a lot of time to debug due to this misleading message. The
meaning of the original message is wrong. We will remove the actor at the
termination of each operator, it has nothing to do with crash. The crash case
is really rare, but this message prints at each termination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
