aglinxinyuan commented on code in PR #6797:
URL: https://github.com/apache/texera/pull/6797#discussion_r3635638485
##########
amber/src/main/python/core/runnables/main_loop.py:
##########
@@ -470,7 +470,7 @@ def _process_ecm(self, ecm_element: ECMElement):
active_channel_id
) in self.context.output_manager.get_output_channel_ids():
if active_channel_id in downstream_channels_in_scope:
- logger.info(
+ logger.debug(
f"send ECM to {active_channel_id},"
f" id = {ecm.id}, cmd = {command}"
)
Review Comment:
Done in 6812804910 — switched to loguru's `{}`-placeholder form, so the
arguments are only stringified if the record is actually emitted. loguru 0.7.3
returns on `level_no < core.min_level` (`_logger.py:1900`) *before* it reaches
`message.format(*args)` (`:1991`), so with DEBUG disabled — the default, and
the CI `WARN` backstop — the `ChannelIdentity`/`command` `str()` cost is
skipped entirely.
##########
amber/src/main/python/core/runnables/main_loop.py:
##########
@@ -444,7 +444,7 @@ def _process_ecm(self, ecm_element: ECMElement):
ecm = ecm_element.payload
command = ecm.command_mapping.get(self.context.worker_id)
channel_id = self.context.current_input_channel_id
- logger.info(
+ logger.debug(
f"receive channel ECM from {channel_id}, id = {ecm.id}, cmd =
{command}"
)
Review Comment:
Done in 6812804910 — switched to loguru's `{}`-placeholder form, so the
arguments are only stringified if the record is actually emitted. loguru 0.7.3
returns on `level_no < core.min_level` (`_logger.py:1900`) *before* it reaches
`message.format(*args)` (`:1991`), so with DEBUG disabled — the default, and
the CI `WARN` backstop — the `ChannelIdentity`/`command` `str()` cost is
skipped entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
