aglinxinyuan commented on PR #6797:
URL: https://github.com/apache/texera/pull/6797#issuecomment-5053392541
Thanks for the review — addressed in 6812804910.
**Eager formatting on the Python ECM logs** — good catch. Switched the three
`main_loop.py` debug logs from f-strings to loguru's `{}`-placeholder form.
loguru's `_log` returns on `level_no < core.min_level` *before* it reaches
`message.format(*args)` (0.7.3, `_logger.py:1900` vs `:1991`), so the
`ChannelIdentity`/command stringification is now skipped entirely when DEBUG is
off — i.e. the default, and the CI backstop (`WARN`) case.
**Eager formatting on the Scala logs** (`DataProcessor`, `ClientActor`) —
left as-is. These go through `com.typesafe.scala-logging` 3.9.6, whose
`Logger.debug`/`warn`/… are macros that expand to `if
(underlying.isDebugEnabled) underlying.debug(…)`, so the `s"…"` interpolation
isn't built when the level is disabled. Moving to SLF4J `{}` placeholders would
be non-idiomatic here and buys nothing.
**Misleading "might have crashed" wording** (`PekkoActorRefMappingService`)
— agreed. `removeActorRef` also runs on normal graceful region teardown, so the
old text was misleading even at DEBUG. Reworded to a neutral `removed actor ref
for <id>. old ref = <ref>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
