[
https://issues.apache.org/jira/browse/YETUS-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047555#comment-15047555
]
Chris Nauroth commented on YETUS-221:
-------------------------------------
We saw this in a pre-commit run for YARN-4248. See my comment here for more
analysis:
https://issues.apache.org/jira/browse/YARN-4248?focusedCommentId=15047553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15047553
Maybe we can use the {{--fail-at-end}} switch to guarantee a full license check.
> asflicense check exits multi-module Maven build early if there are
> pre-existing license problems.
> -------------------------------------------------------------------------------------------------
>
> Key: YETUS-221
> URL: https://issues.apache.org/jira/browse/YETUS-221
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
> Reporter: Chris Nauroth
>
> The asflicense check runs {{mvn apache-rat:check}} from the root of the
> project. For a multi-module build, the build exits with failure after the
> first occurrence of a module with a license problem. It won't check
> subsequent modules. If the patch in question is touching one of those
> subsequent modules, then asflicense won't check it. A reviewer might
> incorrectly conclude that the patch is fine, because the pre-existing license
> problems are unrelated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
