[
https://issues.apache.org/jira/browse/YETUS-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15051338#comment-15051338
]
Sean Busbey commented on YETUS-221:
-----------------------------------
{quote}
The options as I see it at this point:
1. Use --fail-never. Don't trust the exit code. Instead, trust the grep counts
of the output.
2. Resolve it as Won't Fix. Having a license violation checked in to a codebase
is a rare edge case, and it always gets corrected quickly. Maybe it's not worth
the complexity trying to solve for it.
{quote}
3. always rely on the rat jar version of doing license checks, since it will
gladly check all the source files without knowledge or concern about maven
module handling.
> asflicense check exits multi-module Maven build early if there are
> pre-existing license problems.
> -------------------------------------------------------------------------------------------------
>
> Key: YETUS-221
> URL: https://issues.apache.org/jira/browse/YETUS-221
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
> Reporter: Chris Nauroth
> Assignee: Allen Wittenauer
> Attachments: YETUS-221.00.patch, YETUS-221.01.patch
>
>
> The asflicense check runs {{mvn apache-rat:check}} from the root of the
> project (unless told otherwise). For a multi-module build, the build exits
> with failure after the first occurrence of a module with a license problem.
> It won't check subsequent modules. If the patch in question is touching one
> of those subsequent modules, then asflicense won't check it. A reviewer
> might incorrectly conclude that the patch is fine, because the pre-existing
> license problems are unrelated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
