[
https://issues.apache.org/jira/browse/YETUS-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047570#comment-15047570
]
Chris Nauroth commented on YETUS-221:
-------------------------------------
Local repro using the Hadoop project:
{code}
git checkout 86c95cb31a392d2ee4dcf3cc36e924ad34000b27
/bin/bash ~/git/yetus/precommit/test-patch.sh \
--project=hadoop \
--skip-dir=dev-support \
--mv-patch-dir \
--findbugs-strict-precheck \
--findbugs-home=~/findbugs-1.3.9 \
--skip-dirs=dev-support \
--dirty-workspace \
~/patch/YARN-4248.6.patch
{code}
patch-asflicense-root.txt will show that the build failed in Apache Hadoop HDFS
Client, and it skipped all subsequent modules.
> asflicense check exits multi-module Maven build early if there are
> pre-existing license problems.
> -------------------------------------------------------------------------------------------------
>
> Key: YETUS-221
> URL: https://issues.apache.org/jira/browse/YETUS-221
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
> Reporter: Chris Nauroth
>
> The asflicense check runs {{mvn apache-rat:check}} from the root of the
> project. For a multi-module build, the build exits with failure after the
> first occurrence of a module with a license problem. It won't check
> subsequent modules. If the patch in question is touching one of those
> subsequent modules, then asflicense won't check it. A reviewer might
> incorrectly conclude that the patch is fine, because the pre-existing license
> problems are unrelated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
