[ 
https://issues.apache.org/jira/browse/YETUS-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056338#comment-15056338
 ] 

Allen Wittenauer commented on YETUS-221:
----------------------------------------

bq.  always rely on the rat jar version of doing license checks, since it will 
gladly check all the source files without knowledge or concern about maven 
module handling.

That puts a bit of burden on either Yetus to always download it or on the 
project's build system to do something.

> asflicense check exits multi-module Maven build early if there are 
> pre-existing license problems.
> -------------------------------------------------------------------------------------------------
>
>                 Key: YETUS-221
>                 URL: https://issues.apache.org/jira/browse/YETUS-221
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>            Reporter: Chris Nauroth
>            Assignee: Allen Wittenauer
>         Attachments: YETUS-221.00.patch, YETUS-221.01.patch
>
>
> The asflicense check runs {{mvn apache-rat:check}} from the root of the 
> project (unless told otherwise).  For a multi-module build, the build exits 
> with failure after the first occurrence of a module with a license problem.  
> It won't check subsequent modules.  If the patch in question is touching one 
> of those subsequent modules, then asflicense won't check it.  A reviewer 
> might incorrectly conclude that the patch is fine, because the pre-existing 
> license problems are unrelated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to