[
https://issues.apache.org/jira/browse/YETUS-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328113#comment-16328113
]
Duo Zhang commented on YETUS-594:
---------------------------------
First I had a little concern on passing the password through the command line.
But after I saw the jenkins job, I noticed that we use an env variable to pass
the password to the command line which is good, and checked the console output
where we do not leak the password either as the command line output has a mask.
{noformat}
+ python
/home/jenkins/jenkins-slave/workspace/PreCommit-Yetus-Admin/src/precommit/jenkins/jenkins-admin.py
'--jira-filter=https://issues.apache.org/jira/sr/jira.issueviews:searchrequest-xml/12323182/SearchRequest-12323182.xml?tempMax=50'
--jenkins-url=https://builds.apache.org
'--jenkins-project-template=PreCommit-{project}-Build' --jenkins-token=hadoopqa
--jira-user=[*******] '--jira-password=[*******]'
{noformat}
+1. Great work!
> Fix up the jenkins precommit script
> -----------------------------------
>
> Key: YETUS-594
> URL: https://issues.apache.org/jira/browse/YETUS-594
> Project: Yetus
> Issue Type: Improvement
> Components: Test Patch
> Affects Versions: 0.7.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Blocker
> Fix For: 0.7.0
>
> Attachments: YETUS-594.00.patch, YETUS-594.01.patch,
> YETUS-594.01.patch, YETUS-594.03.patch
>
>
> With YETUS-288 committed, there are a bunch of things that need to get done
> to make it more digest-able for those outside of the ASF:
> - documentation
> - pylint
> - make a default token
> - saner defaults
> - authentication
> ...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
