TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server URL: https://github.com/apache/zookeeper/pull/1049#discussion_r312866880
########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/client/HostProvider.java ########## @@ -18,58 +18,60 @@ package org.apache.zookeeper.client; -import org.apache.yetus.audience.InterfaceAudience; - import java.net.InetSocketAddress; import java.util.Collection; +import org.apache.yetus.audience.InterfaceAudience; /** * A set of hosts a ZooKeeper client should connect to. - * - * Classes implementing this interface must guarantee the following: - * - * * Every call to next() returns an InetSocketAddress. So the iterator never - * ends. - * - * * The size() of a HostProvider may never be zero. - * - * A HostProvider must return resolved InetSocketAddress instances on next() if the next address is resolvable. + * + * <p>Classes implementing this interface must guarantee the following: + * + * <ul> + * <li>Every call to next() returns an InetSocketAddress. So the iterator never ends.</li> + * <li>The size() of a HostProvider may never be zero.</li> + * </ul> + * + * <p>A HostProvider must return resolved InetSocketAddress instances on next() if the next address is resolvable. * In that case, it's up to the HostProvider, whether it returns the next resolvable address in the list or return * the next one as UnResolved. - * - * Different HostProvider could be imagined: - * - * * A HostProvider that loads the list of Hosts from an URL or from DNS - * * A HostProvider that re-resolves the InetSocketAddress after a timeout. - * * A HostProvider that prefers nearby hosts. + * + * <p>ifferent HostProvider could be imagined: Review comment: Nice catch. Fixing... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
