changruill commented on code in PR #1925:
URL: https://github.com/apache/zookeeper/pull/1925#discussion_r1198591366
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java:
##########
@@ -155,11 +155,11 @@ protected void unregisterMetrics() {
}
@Override
- public synchronized void shutdown() {
+ public synchronized void shutdown(boolean fullyShutDown) {
Review Comment:
I'm a little worried about the modification here has an impact on the
invoking chain.
Before modification: Leader.shutdown(String) ->
LeaderZooKeeperServer.shutdown() -> ZooKeeperServer.shutdown()
After modification: Leader.shutdown() -> ZooKeeperServer.shutdown()
LeaderZooKeeperServer.shutdown is skipped and containerManager does not stop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
