RabbitDong-on commented on code in PR #1925:
URL: https://github.com/apache/zookeeper/pull/1925#discussion_r1247708833
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/SendAckRequestProcessor.java:
##########
@@ -64,7 +66,8 @@ public void flush() throws IOException {
} catch (IOException e) {
LOG.warn("Closing connection to leader, exception during packet
send", e);
try {
- if (!learner.sock.isClosed()) {
+ Socket socket = learner.sock;
+ if ( socket != null && ! learner.sock.isClosed()) {
Review Comment:
hi jonmv, i have read the jira-4541. I am confusing. ZK1 does not send ack
to leader , ZK1 recieves commit from leader. It seems not conform ZAB
protocol. Please help me figure out, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
