jonmv commented on code in PR #1925:
URL: https://github.com/apache/zookeeper/pull/1925#discussion_r1198615783
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java:
##########
@@ -155,11 +155,11 @@ protected void unregisterMetrics() {
}
@Override
- public synchronized void shutdown() {
+ public synchronized void shutdown(boolean fullyShutDown) {
Review Comment:
`ZooKeeperServer.shutdown()` only calls `shutdown(false)`, which is
implemented in `LeaderZooKeeperServer`, and which stops the `containerManager`.
`shutdown()` isn't overridden anywhere anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
