jonmv commented on code in PR #1925: URL: https://github.com/apache/zookeeper/pull/1925#discussion_r1153562283
########## zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java: ########## @@ -106,6 +106,8 @@ protected void setupRequestProcessors() { if (syncRequestProcessorEnabled) { syncProcessor = new SyncRequestProcessor(this, null); syncProcessor.start(); + } else { + syncProcessor = null; Review Comment: No, I'm just used to always assigning (to final fields). This can be removed again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org