On Thu, Jan 06, 2022 at 12:36:39PM -0800, Ira Weiny wrote:
> On Mon, Jan 03, 2022 at 12:16:13PM -0800, Schofield, Alison wrote:
> > From: Alison Schofield <alison.schofi...@intel.com>
> >
> > Add accessors to retrieve total capacity, volatile only capacity,
> > and persistent only capacity from the IDENTIFY mailbox command.
> > These values are useful when partitioning the device.
>
> Reword:
>
> The total capacity, volatile only capacity, and persistent only capacity are
> required to properly formulate a set partition info command.
>
> Provide functions to retrieve these values from the IDENTIFY command. Like
> the
> partition information commands these return the values in bytes.
>
Will reword. Thanks.
> >
> > +
> > +CXL_EXPORT unsigned long long
> > +cxl_cmd_identify_get_total_capacity(struct cxl_cmd *cmd)
>
> Is there someplace that all the libcxl functions are documented? Like the
> other functions I would like to ensure the user knows these are returning
> values in bytes.
There is a libcxl manpage, source at:
ndctl/Documentation/cxl/lib/libcxl.txt
Synopsis is:
#include <cxl/libcxl.h>
cc ... -lcxl
It describes how to use libcxl, ie alloc, submit, and get info back from
a command. I believe the intent is the user references cxl/libcxl.h to
find the accessors available. Along that line, it doesn't make any
sweeping statements about formats of data returned and I believe, based
on Dan's comments about the long descriptive names, that is by design.
ie. the name should say it all.
I'll rename these all to be _bytes instead of _capacity, as you
suggested in the prior patch.
>
> Ira
>
snip
> > +{
