On Thu, Jan 06, 2022 at 12:49:05PM -0800, Ira Weiny wrote:
> On Mon, Jan 03, 2022 at 12:16:15PM -0800, Schofield, Alison wrote:
> > From: Alison Schofield <[email protected]>
> >
>
> "Users will want to be able to check the current partition information. In
> addition they will need to know the capacity values to form a valid set
> partition information command."
>
I do see the pattern you are after. Problem statement separate from
solution statement. Will reword.
> > Add information useful for managing memdev partitions to cxl-list
> ^
> "optional"
>
> > output. Include all of the fields from GET_PARTITION_INFO and the
> > partitioning related fields from the IDENTIFY mailbox command.
> >
>
> "Sample output for this section is:"
>
> > "partition":{
> > "active_volatile_capacity":273535729664,
> > "active_persistent_capacity":0,
> > "next_volatile_capacity":0,
> > "next_persistent_capacity":0,
> > "total_capacity":273535729664,
> > "volatile_only_capacity":0,
> > "persistent_only_capacity":0,
> > "partition_alignment":268435456
> > }
> >
snip
> > + if (jobj)
> > + json_object_object_add(jpart, "partition_alignment", jobj);
> > +
> > + return jpart;
> > +
> > +err_cmd:
>
> Doesn't this need to be called always, not just on error?
cxl_cmd_unref(), sure does. Thanks for the catch!
>
> Ira
>
