On Mon, Jan 03, 2022 at 12:16:17PM -0800, Schofield, Alison wrote: > From: Alison Schofield <[email protected]> > > The OPT_U64 define failed in check_vtype() with unknown 'u64' type. > Replace with 'unsigned long long' to make the OPT_U64 define usable.
I feel like this should be the first patch in the series. > > Signed-off-by: Alison Schofield <[email protected]> > --- > util/parse-options.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/util/parse-options.h b/util/parse-options.h > index 9318fe7..91b7932 100644 > --- a/util/parse-options.h > +++ b/util/parse-options.h > @@ -124,7 +124,7 @@ struct option { > #define OPT_INTEGER(s, l, v, h) { .type = OPTION_INTEGER, .short_name = > (s), .long_name = (l), .value = check_vtype(v, int *), .help = (h) } > #define OPT_UINTEGER(s, l, v, h) { .type = OPTION_UINTEGER, .short_name = > (s), .long_name = (l), .value = check_vtype(v, unsigned int *), .help = (h) } > #define OPT_LONG(s, l, v, h) { .type = OPTION_LONG, .short_name = > (s), .long_name = (l), .value = check_vtype(v, long *), .help = (h) } > -#define OPT_U64(s, l, v, h) { .type = OPTION_U64, .short_name = (s), > .long_name = (l), .value = check_vtype(v, u64 *), .help = (h) } > +#define OPT_U64(s, l, v, h) { .type = OPTION_U64, .short_name = (s), > .long_name = (l), .value = check_vtype(v, unsigned long long *), .help = (h) } Why can't this be uint64_t? Ira > #define OPT_STRING(s, l, v, a, h) { .type = OPTION_STRING, .short_name = > (s), .long_name = (l), .value = check_vtype(v, const char **), (a), .help = > (h) } > #define OPT_FILENAME(s, l, v, a, h) { .type = OPTION_FILENAME, .short_name = > (s), .long_name = (l), .value = check_vtype(v, const char **), (a), .help = > (h) } > #define OPT_DATE(s, l, v, h) \ > -- > 2.31.1 >
