On Thu, Jan 06, 2022 at 12:53:02PM -0800, Ira Weiny wrote: > On Mon, Jan 03, 2022 at 12:16:16PM -0800, Schofield, Alison wrote: > > From: Alison Schofield <[email protected]> > > > > Add APIs to allocate and send a SET_PARTITION_INFO mailbox command. > > > > + le64 volatile_capacity; > > + u8 flags; > > +} __attribute__((packed)); > > + > > +/* CXL 2.0 8.2.9.5.2 Set Partition Info */ > > +#define CXL_CMD_SET_PARTITION_INFO_NO_FLAG (0) > > +#define CXL_CMD_SET_PARTITION_INFO_IMMEDIATE_FLAG (1) > > BIT(0) and BIT(1)? > > I can't remember which bit is the immediate flag. > Immediate flag is BIT(0). Seemed awkward/overkill to use bit macro - +#define CXL_CMD_SET_PARTITION_INFO_NO_FLAG (0) +#define CXL_CMD_SET_PARTITION_INFO_IMMEDIATE_FLAG BIT(1)
I just added api to use this so you'll see it in action in v2 of this patchset and can comment again.
