On Thu, Aug 27, 2009 at 03:09:20PM -0700, Michael Hunter wrote:
> /net/coupe.eng/builds/mph/nwam1_work/
>
> Changes cover:
> 10456 automatic: wired and wireless up
> 10605 lost state changes
> collapse door_switch logging
>
> Please review.
A few comments, mostly nits.
-renee
events.c
743: a comma after 'can' will make this more readable
752-53: I know 'rc' does not imply a number to everyone, but it does to me,
and *I* find this code confusing as a result. Maybe a more
descriptive name for this boolean would be a compromise: something
like 'selected'?
759,769: Doesn't cstyle want spaces around the '+'?
ncp.c
394-95: If this is going to stay in, the latter three parameters should
be converted to strings.
550: A comment explaining what this function does would be helpful.
557-58: This message is a little misleading, as we're really deactivating
all groups of lower or equal priority to the one given.
578: Spaces around '+'?
582: s/Returns if it.../Returns 'true' if it.../
ncu.c
1211: This debug message is a little cryptic...should either remove it or
make it more specific.
ncu_phys.c
1759: Indeed! Need to resolve the XXX somehow...
>
> mph
> _______________________________________________
> nwam-dev mailing list
> nwam-dev at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/nwam-dev
