On Thu, 27 Aug 2009 18:46:47 -0700
Renee Danson Sommerfeld <renee.sommerfeld at sun.com> wrote:
[...]
> > > 759,769: Doesn't cstyle want spaces around the '+'?
> >
> > It didn't barf on this code. But I added them in since it makes it
> > easier for some to read the code. Some might not like my new choice on
> > 759 though...
>
> Yeah, I was afraid of that. How about making next_priority_group just
> a bit shorter (next_prio_group)?
I went all the way down to prio. I think the shorter identifier is
easier on the eyes and communicates the same thing.
>
> > > ncu_phys.c
> > > 1759: Indeed! Need to resolve the XXX somehow...
> >
> > If I figure it out I'll change it but I really think Alan needs to give
> > us some insight.
>
> Okay...but this needs to be dealt with before we integrate.
Agreed.
New webrev (and I'll probably have another one tomorrow morning with a
few more things in it esp. a fix for a problem I see with IPv4 static
addresses).
mph
>
> -renee
