The README definitely needs to be expanded/added with the QUEUE_QUIET
stuff and the event handling logic. I think I know how it works, but
not entirely sure.
ncp.c
Why can't nwamd_ncp_deactivate_priority_group_all() call
nwamd_ncp_deactivate_priority_group() with lower priority group
numbers. same logic in two places.
bzero()ing the nwamd_ncu_check_walk_arg and then filling in the values
is more elegant.
nwamd_ncp_check_priority_group() doesn't find priority-group higher than
the one passed in. Is it supposed to always start the search at 0?
events.c
shouldn't the timed condition checking also go though the queue
quieting? It and the triggered condition checking can stomp on top of
each other.
ncu.c
1187, 1191, 1637: unnecessary { ... }
ncu_ip.c:697 smf_restore_instance() before smf_refresh_instance() in
case network/location is in maintenance.
do_dhcp_release() can be static.
688-702 duplicates what follows in 722-738.
at 714, is a "return;" missing? otherwise the state changes to online/up
in 722.
ncu_phys.c
comment 1744-1748 seems appropriate at 1759
why is 1774-1776 moved out from 1798? We don't have NCUs with lower
priority (ie bigger numbers) going to up state.
also, why 1830-1832 outside of priority group checking?
Anirag
