On Thu, Aug 27, 2009 at 05:33:59PM -0700, Michael Hunter wrote: > On Thu, 27 Aug 2009 16:48:27 -0700 > Renee Danson Sommerfeld <renee.sommerfeld at sun.com> wrote: > > > On Thu, Aug 27, 2009 at 03:09:20PM -0700, Michael Hunter wrote: > > > /net/coupe.eng/builds/mph/nwam1_work/ > > > > > > Changes cover: > > > 10456 automatic: wired and wireless up > > > 10605 lost state changes > > > collapse door_switch logging > > > > > > Please review. > > > > A few comments, mostly nits. > > > > -renee > > > > 759,769: Doesn't cstyle want spaces around the '+'? > > It didn't barf on this code. But I added them in since it makes it > easier for some to read the code. Some might not like my new choice on > 759 though...
Yeah, I was afraid of that. How about making next_priority_group just a bit shorter (next_prio_group)? > > ncu_phys.c > > 1759: Indeed! Need to resolve the XXX somehow... > > If I figure it out I'll change it but I really think Alan needs to give > us some insight. Okay...but this needs to be dealt with before we integrate. -renee
