On Thu, 08 Oct 2009 13:31:37 +0100
Alan Maguire <Alan.Maguire at Sun.COM> wrote:
> Michael Hunter wrote:
> > Code review corrections. Note that the removal of the broken soft
> > reset file code will result in a (post integration) RFE.
> >
> > file:///net/coupe.eng/builds/mph/nwam1_cr_fixes/webrev/index.htm
> >
> >
> dlpi_events.c:
>
> as Renee says, I think we need the check for the wifi
> case. For wired, we delete and re-add the thread to
> trigger link state events on init, but for wireless we
> don't bother since we ignore the link state events
> for wifi.
yeap, that is the important case. I ran the binary and cycled between
wired and wireless and we ended up with a bunch of dlpi threads
supporting this.
>
> door_if.c:
>
> nit: we use nwamd_door_initialize() but in most
> other places we abbreviate to "init". Might be no
> harm to change the name for consistency (especially
> since we use nwamd_door_fini() below).
done.
I'll put out a new webrev in a bit. The server my code is on seems to
be running through mud at the moment.
mph
>
> Alan
