On Wed, 07 Oct 2009 17:40:26 -0700
Renee Danson Sommerfeld <renee.sommerfeld at sun.com> wrote:
> On Wed, Oct 07, 2009 at 04:58:48PM -0700, Michael Hunter wrote:
> > Code review corrections. Note that the removal of the broken soft
> > reset file code will result in a (post integration) RFE.
> >
> > file:///net/coupe.eng/builds/mph/nwam1_cr_fixes/webrev/index.htm
>
> dlpi_events.c, line 92: I would add a colon so it reads
> 'dlpi_recv failed: <error string>'
ACCEPT
>
> dlpi_events.c, 115-121: I think we need this check. We delete/add
> the link frequently, as a 'reset state' mechanism; in the wired
> case, it looks like we always delete immediately before adding,
> but it's not clear that's true for the wireless case. Not sure
> what the answer is, but I think what's there now is problematic.
ACCEPT
>
> Everything else looks fine.
new webrev for your perusal.
mph
>
> -renee
