[ 
https://issues.apache.org/jira/browse/OAK-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421295#comment-13421295
 ] 

Jukka Zitting commented on OAK-182:
-----------------------------------

Looks good, though note the following:

* No need to call {{PathUtils.getName()}} in {{NodeStateUtils.isHidden()}} as 
the given name is not a path.
* I think the {{ValidatingEditor}} shouldn't ignore hidden content. Individual 
{{Validator}} classes that the {{ValidatingEditor}} calls may or may not want 
to do so, but it should be up to them to decide.
* Similarly, the {{MergingNodeStateDiff}} class probably shouldn't ignore 
hidden content. We want to be able to properly merge also such content.
                
> Support for "invisible" internal content
> ----------------------------------------
>
>                 Key: OAK-182
>                 URL: https://issues.apache.org/jira/browse/OAK-182
>             Project: Jackrabbit Oak
>          Issue Type: New Feature
>          Components: core, jcr
>            Reporter: Jukka Zitting
>         Attachments: OAK-182-b.patch
>
>
> As discussed on the mailing list 
> (http://markmail.org/message/kzt7csiz2bd5n3ww), it would be good to have a 
> naming pattern line "{{:name}}" for internal content that we don't want to 
> directly expose to JCR clients.
> JCR-related functionality like the namespace and node type validators and the 
> observation dispatcher (see also OAK-181) should know to ignore such content 
> and the JCR binding in oak-jcr should automatically filter out such internal 
> content. Such internal content should probably also not be indexed for search.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to