On Thu, 2017-04-13 at 15:03 +0530, Chetan Mehrotra wrote: > On Thu, Apr 13, 2017 at 2:51 PM, Marcel Reutegger <[email protected] > > wrote: > > one concern I have is maintainability. Scripts tend to go out of > > date and my > > question would be how we can detect this when it happens. > > Yes that would be the case. The scripts come with lesser testing and > can go stale > > > I'm wondering why this is > > implemented as a script instead of plain Java. I'd say if we > > consider this > > an important functionality that should be added to Oak, then it is > > probably > > better to integrate it better, with tests, documentation, etc. > > There is OAK-5558 for that but that would take time and then also it > might not be present in old branches. > > Major benefit of scripts are they are faster to implement and can be > used in older branches without impacting runtime. Commonly used > script > can then later be supported in a proper way (MBean, oak-run command > etc). For now I have quite a bit of them in my github (and few other > devs also maintain such scripts). So idea here was to consolidate > such > common scripts at one place.
Maybe a good compromise to place then in a non-releasable module - or just a directory is fine. This way they are not released as other modules, and are clearly defined as 'your mileage may vary'. One option is oak-run/contrib/scripts . Or we can even have a 'contrib' area in the top-level oak directory and place the scripts there, i.e. /contrib/scripts or /contrib/oak-run-scripts , to make it clear what kind of scripts these are. Robert
