Hi Konrad,

Adding the oak-dev list for feedback. I already gathered some inputs from
Marcel on Slack.

System View can not import versions. I could not find an internal API that
support importing existing versions either. Also the VersionManagerImpl
does not yet support merge operation, see OAK-1402.

IIUC we would need to

1. Add support for merging versions into a version history which is
essentially OAK-1402
2. Extend System View importer to handle version history protected nodes.
This would take the form of a o.a.j.o.s.x.ProtectedNodeImporter
implementation targeting rep:versionStorage, nt:versionHistory, nt:version,
and nt:frozenNode
3. Extend the VersionStorageEditor to support merging history nodes using
the ReadWriteVersionManager
4. Extend FileVault to import nodes under /jcr:system/jcr:versionStorage
using the System View

Does the general approach make sense ? If so we could build a prototype.

Regards,

Timothee

Le mar. 19 avr. 2022 à 11:48, Konrad Windszus <[email protected]> a écrit :

> Hi Timothee,
> I am happy to review PRs for adding that feature. Not sure if Oak can
> import versions via sysview, have you tried that? In the worst case a
> dedicated import handler needs to be added which recreates the versions
> with JCR API (not sure if that can set certain metadata of the version).
> It would be nice though if that feature would not depend on Oak impl or
> API though.
> However, I would extend the filter.xml with additional attributes both for
> exporting and importing versions to not rely on internals like the
> repository location of versions.
> Konrad
>
> > Am 19.04.2022 um 11:31 schrieb Timothee Maret <[email protected]>:
> >
> > 
> > Hi,
> >
> > FileVault does not seem to support versions. A resource like cq:Page is
> stripped of its versioning properties [0] upon export. Also, the version
> storage under /jcr:system/jcr:versionStorage can be exported but not
> imported as versioning properties are protected.
> >
> > Is this limited by design ? If not, how about including the versioning
> properties in the export and using the System View to import them ?
> >
> > Regards,
> >
> > Timothee
> >
> > [0] jcr:predecessors, jcr:baseVersion, jcr:successors, and
> jcr:versionHistory
>
>

Reply via email to