rishabhdaim commented on code in PR #1562:
URL: https://github.com/apache/jackrabbit-oak/pull/1562#discussion_r1703744633
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGCRecommendations.java:
##########
@@ -345,20 +350,31 @@ private Map<String, Object> getVGCSettings() {
return settings;
}
- private void setLongSetting(String propName, long val) {
- setLongSetting(of(propName, val));
+ private void setVGCSetting(final String propName, final Object val) {
+ setVGCSetting(new HashMap<>() {{
Review Comment:
oh, didn't know the performance aspect of this. Will make the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
