stefan-egli commented on PR #1562: URL: https://github.com/apache/jackrabbit-oak/pull/1562#issuecomment-2284014337
Started rereviewing and must admit that it's perhaps not immediately obvious why we use `update` in one case and `set` in the other. Then I noticed that the jira as well doesn't much go into details as to what exactly the race condition is. The PR does : > (fixed) race condition where fullGC database variables gets overridden if they are reset by external components What about adding a comment to the jira that explains what goes wrong when "the race condition" happens? I guess it is : when you do a reset using oak-run while an oak instance is executing a regular fullGC (not dry run), then the reset would be ignored? And at the same time perhaps why dry run is different from wet run in this regard? Just might make code reading a bit easier. PS: also noticed that due to the force-push I can't review the diff between my last review and this one - so can't follow what has changed since. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
