stefan-egli commented on PR #1605: URL: https://github.com/apache/jackrabbit-oak/pull/1605#issuecomment-2288349374
What about splitting the two parts, as you suggested, into two different PRs? I would tend to prefer if OAK-10875 would stay open as I believe both parts are required? But they could certainly be split into two PRs to simplify things. Wdyt? Btw: there's something odd going on with this PR as it seems to duplicate the original : eg [unmergedBCOnRoot](https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/BranchTest.java#L117) is already there in trunk, but this PR adds it again, same with the changes of FailingDocumentStore. The [CI](https://ci-builds.apache.org/job/Jackrabbit/job/oak-trunk-pr/job/PR-1605/5/cloudbees-pipeline-explorer/?filter=52) currently complains with ``` [ERROR] /home/jenkins/jenkins-agent/workspace/Jackrabbit_oak-trunk-pr_PR-1605/oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/BranchTest.java:[317,18] method invalidateCommitValueResolverCache(org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore) is already defined in class org.apache.jackrabbit.oak.plugins.document.BranchTest ``` I think originally the PR was complaining it can't merge due to these duplications - now it doesn't do that anymore. No idea why... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
