stefan-egli commented on code in PR #1605:
URL: https://github.com/apache/jackrabbit-oak/pull/1605#discussion_r1725182349
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocument.java:
##########
@@ -1943,6 +1943,9 @@ public static void setBranchCommit(@NotNull UpdateOp op,
public static void removeBranchCommit(@NotNull UpdateOp op,
@NotNull Revision revision) {
checkNotNull(op).removeMapEntry(BRANCH_COMMITS, revision);
+ if (op.getId().equals(Utils.getIdFromPath("/"))) {
+ checkNotNull(op).removeMapEntry(COMMIT_ROOT, revision);
+ }
Review Comment:
(going to close this conversation here, which was primarily about part 1 -
for which now I think the way the PR is now is fine)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
