Amoratinos commented on PR #1715: URL: https://github.com/apache/jackrabbit-oak/pull/1715#issuecomment-2352204744
>and make sure that in the default setup we always get the cache property written. The `MEMBERSHIP_THRESHOLD` cannot be changed by configuration so changing to `< MEMBERSHIP_THRESHOLD` will have the same effect like remove the condition, which is also fine for me. > we have no test coverage for the situation when the cache is not present and cannot be written There's a test when the cache cannot be written or an exception is triggered. https://github.com/apache/jackrabbit-oak/blob/fd78e686ffce2369766519964a3c42d9ff3e03cf/oak-core/src/test/java/org/apache/jackrabbit/oak/security/user/CachedPrincipalMembershipReaderTest.java#L138-L150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
