anchela commented on PR #1715: URL: https://github.com/apache/jackrabbit-oak/pull/1715#issuecomment-2359047412
@Amoratinos , i get a build failure due to lack of branch coverage: [WARNING] Rule violated for package org.apache.jackrabbit.oak.security.user: branches covered ratio is 0.98, but expected minimum is 0.99 the new method hasCacheValues(@NotNull Tree principalCache) only has 50% branch coverage and the condition if (canServeStaleCache(expirationTime, now) && hasCacheValues(principalCache)) also doesn't have full coverage. i guess this the reason for the drop of coverage. once the build passes i will merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
